To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~558

Documentation is deployed and generated using docs.page.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ spydon
✅ Salakar
❌ cameron-klein
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Thanks! I signed the agreement but it doesn't seem to be updating. I've clicked the recheck link a few times but no luck. It's also not letting me sign it again.

Thanks for fixing this. Do you know when can we merge this? this is impacting our workflows as well.

Is there any implications on reversing this? I understand the original change was done mainly for cleanup but not sure the reasoning of switching the diff logic.

Maybe there is there an interim way we can support both for now that way we ship it faster and worry about reversal implications later?

@cameronklein did you see the questions from Salakar? :)

It does make sense to support both but I personally don't have the bandwidth. We've forked the repo and made the change for our use case. I'll keep the issue (#557) open for anyone that does have more time!

It does make sense to support both but I personally don't have the bandwidth. We've forked the repo and made the change for our use case. I'll keep the issue (#557) open for anyone that does have more time!

Maybe it is worth opening up and merging this anyways, is there any usecase for supporting both? Isn't this way just "more correct"?

Yes, I agree. @cameron-klein can you please re-open this PR and we can hopefully get it merged this time? Thanks

It would be great to have your input here @blaugold, because I don't fully get it there would be any downsides.

Hey @blaugold can you please take a look at this today? Thanks

Hey @spydon, what do you suggest we should do next?

Hey @spydon, what do you suggest we should do next?

Could you open up a new PR with the only changes that are needed from this PR and I could get some other people to review it too? And I'll do some more research on what these changes would entail, so that I can review it better.

Sorry for the delay. I'm taking a look at it now.

If I remember correctly, I moved from git diff to git log for detecting changes in a package only for simplifying things and not for any functionality.

These changes look to me like they only improve the correctness of --diff and I can't see any functionality being taken away. I think it makes sense to merge this PR.